Convert Mix_Music forward declare to include in Music.h
#1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Mix_Music` typedef points to a `struct` that was renamed. There's no easy way to deal with that and maintain a forward declare. We would need to forward declare for one of two possible type names, before we've seen the include that would tell us which name it should be. I suppose we could add some pointer casting, but that should be avoided. Considering how infrequently the `Music.h` header is included by other files, we're probably fine doing a full SDL include for now. Once things have stabilized on the new version we could eventually switch back to a forward declare. As a bonus, that forward declare will then be for a name that is not reserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Mix_Musictypedef points to astructthat was renamed. There's no easy way to deal with that and maintain a forward declare. We would need to forward declare for one of two possible type names, before we've seen the include that would tell us which name it should be.I suppose we could add some pointer casting, but that should be avoided.
Considering how infrequently the
Music.hheader is included by other files, we're probably fine doing a full SDL include for now. Once things have stabilized on the new version we could eventually switch back to a forward declare. As a bonus, that forward declare will then be for a name that is not reserved.Closes #1242
Related:
Music.hfor SDL_Mixer2.8.1#1242Musicto separate cache file OutpostUniverse/OPHD#1655